Hi Laurent, On Wed, Sep 11, 2013 at 7:46 AM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > Hi Magnus, > > On Wednesday 11 September 2013 07:40:54 Magnus Damm wrote: >> Hi Guennadi, >> >> [CC Simon, Laurent] >> >> On Tue, Sep 10, 2013 at 12:55 AM, Guennadi Liakhovetski wrote: >> > This patch adds Device Tree support to the i2c-rcar driver and respective >> > documentation. >> > >> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@xxxxxxxxx> >> > --- >> > >> > Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 22 +++++++++++++++ >> > drivers/i2c/busses/i2c-rcar.c | 20 ++++++++++++++- >> > 2 files changed, 40 insertions(+), 2 deletions(-) >> > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-rcar.txt >> > >> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt >> > b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt new file mode 100644 >> > index 0000000..b3c030b >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt >> > @@ -0,0 +1,22 @@ >> > +I2C for R-Car platforms >> > + >> > +Required properties: >> > +- compatible: Must be one of >> > + "renesas,i2c-rcar" >> > + "renesas,i2c-rcar-h1" >> > + "renesas,i2c-rcar-h2" >> >> Is this following the same style as other DT patches? It looks to me >> that you may want to use r8a7779 and r8a7790 instead of h1 and h2. >> >> Simon, Laurent, what do you think about this? > > I think that should be "renesas,i2c-r8a7779" and "renesas,i2c-r8a7790", yes. Thanks for your comments. I recall that r8a7790 has a bunch of channels and at least two types of i2c controllers. I wonder what the proper naming would be then... / magnus -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
