On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > > Fix build warnings when CONFIG_OF is not enabled: It would be nice to know what arch/config you see this on. > include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside parameter list [enabled by default] > include/linux/of_irq.h:82:7: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside parameter list [enabled by default] > > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Grant Likely <grant.likely@xxxxxxxxxx> > Cc: Rob Herring <rob.herring@xxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > --- > include/linux/of_irq.h | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-next-20130830.orig/include/linux/of_irq.h > +++ linux-next-20130830/include/linux/of_irq.h > @@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_ > #endif /* CONFIG_OF_IRQ */ > > #else /* !CONFIG_OF */ > +struct device_node; Can you move this outside of the ifdefs to minimize the amount of ifdef'ed code. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
