Hello. On 09/03/2013 07:17 PM, Magnus Damm wrote:
Define the generic R8A777x part of the Ether device node.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
--- arch/arm/boot/dts/r8a7778.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+) Index: renesas/arch/arm/boot/dts/r8a7778.dtsi =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7778.dtsi +++ renesas/arch/arm/boot/dts/r8a7778.dtsi @@ -98,4 +98,15 @@ reg = <0xfffc000 0x118>; #gpio-range-cells = <3>; }; + + ether: ethernet@fde00000 { + device_type = "network"; + compatible = "renesas,ether-r8a7779";
Hi Sergei,
Thanks for your patch. What's the reason behind the r8a7778 SoC using a compatible string for r8a7779 like "renesas,ether-r8a7779"?
R8A7779 support has appeared first in Linux and as R8A7778 Ether is identical to R8A7779 and no wildcards are allowed in the device tree, I decided to use this "compatible" prop.
It seems that you assume that the r8a7778 ethernet controller is 100% compatible with r8a7779. Is that really true? For earlier versions the sh_eth hardware documentation was anything but accurate, so it seems to me that it must be more safe that r8a7778 would be using "renesas,ether-r8a7778". What do you think?
I think R8A7778 and R8A7779 EtherMACs are identical. I've cross checked the documentation at the start of the development and the registers appeared to be the same.
Thanks,
/ magnus
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
