> Subject: Re: [PATCH 4/4] Documentation: Add device tree bindings for > Freescale FTM PWM > > On 08/30/2013 01:19 PM, Kumar Gala wrote: > > Should have at least something w/regards to a commit message. > > > > On Aug 20, 2013, at 10:07 PM, Xiubo Li wrote: > > > >> Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx> > >> --- > >> .../devicetree/bindings/pwm/fsl-ftm-pwm.txt | 52 > ++++++++++++++++++++++ > >> 1 file changed, 52 insertions(+) > >> create mode 100644 > >> Documentation/devicetree/bindings/pwm/fsl-ftm-pwm.txt > >> > >> diff --git a/Documentation/devicetree/bindings/pwm/fsl-ftm-pwm.txt > >> b/Documentation/devicetree/bindings/pwm/fsl-ftm-pwm.txt > >> new file mode 100644 > >> index 0000000..698965b > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/pwm/fsl-ftm-pwm.txt > >> @@ -0,0 +1,52 @@ > >> +Freescale FTM PWM controller > >> + > >> +Required properties: > >> +- compatible: should be "fsl,vf610-ftm-pwm" > >> +- reg: physical base address and length of the controller's > >> +registers > >> +- #pwm-cells: Should be 3. Number of cells being used to specify PWM > property. > >> + First cell specifies the per-chip channel index of the PWM to use, > >> +the > >> + second cell is the period in nanoseconds and bit 0 in the third > >> +cell is > >> + used to encode the polarity of PWM output. Set bit 0 of the third > >> +in PWM > >> + specifier to 1 for inverse polarity & set to 0 for normal polarity. > >> +- fsl,pwm-clk-ps: the ftm0 pwm clock's prescaler, divide-by 2^n(n = 0 > ~ 7). > >> +- fsl,pwm-cpwm: Center-Aligned PWM (CPWM) mode. > > > > Should describe this in more detail, what does the value actually mean > for what modes there are? > > Assuming "CPWM" is clearly explained in the HW documentation for this > chip (I have no idea if that's actually the case), then is it still > necessary to explain what this means in *detail*? Perhaps simply "see > section XXX in the TRM" or "see register XXX, bit YYY in the HW > documentation" would be enough? > If to clearly explain the 'CPWM' mode, there maybe need much more words, I think just simply explain it, and then for more detail information "see section XXX in the TRM" or "see register XXX, bit YYY in HW documentation". Thanks. -- Best Regards, Xiubo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
