On Fri, Aug 30, 2013 at 09:06:22PM +0100, David Woodhouse wrote: > On Mon, 2013-08-12 at 14:14 -0300, Ezequiel Garcia wrote: > > There's no need to enclose this code within idef CONFIG_OF, > > because the OF framework provides no-op stubs if CONFIG_OF=n. > > Hm, won't this end up with the same 'pxa3xx_nand_dt_ids is defined but > not used' warning that just caused us to *add* an #ifdef CONFIG_OF to > atmel_nand? > No, it won't. Currently atmel_nand uses its of_device_id for just the of_match_table, while pxa3xx-nand uses the pxa3xx_nand_dt_ids for more than just that, as a paramater for of_match_device(). The latter prevents the warning by having an actual dummy-inlined implementation for the !OF case. I'll answer about the atmel_nand in the respective patch. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
