Re: [PATCH] ARM: dts: vexpress: Add CCI node to TC2 device-tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, Aug 30, 2013 at 05:30:17PM +0100, Olof Johansson wrote:
> On Fri, Aug 30, 2013 at 9:13 AM, Lorenzo Pieralisi
> <lorenzo.pieralisi@xxxxxxx> wrote:
> 
> > Now that MCPM and CPU idle are heading to mainline, it should get queued asap,
> > thanks for that, probably as a fix at -rc1, since it is quite late now.
> 
> This is not a regression, it's a missing piece of a feature. It's not
> post-rc1 material.

It is an incomplete dts, which has been true since the dts file for TC2 has
been merged in the kernel or better since the CCI bindings got merged in
the kernel.

> It's also an indication that nobody actually tested the feature branch
> before the pull request was sent. Hrmpf.

It has been tested and we were aware that the dts in the kernel was missing
the CCI node, we were not really sure about what to do given the ongoing
discussions on dts in the kernel and so on and considered that we might
get the patch in as a fix eventually; we made a mistake, sorry.

> Shouldn't you be updating some vexpress_defconfig and probably
> multi_v7_defconfig to at least get some build coverage for this as
> well, by the way?
> 
> I really should hold this off for 3.13, but I'll apply it to the late/
> branch anyway.

Thanks,
Lorenzo

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux