Re: [PATCH] ARM: dts: update binding document exynos-dw-mshc.txt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Yavaraj,

On Thu, Aug 29, 2013 at 4:53 AM, Yuvaraj Kumar C D <yuvaraj.cd@xxxxxxxxx> wrote:
> This patch updates the exynos-dw-mshc.txt.Currently we are using
> "pinctrl" binding property to describe the CMD and DATA line's
> of Mobile Storage Host Controller(mshc) node.
>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/mmc/exynos-dw-mshc.txt     |   34 ++++++++++----------
>  1 file changed, 17 insertions(+), 17 deletions(-)

This looks good to me, though it's hard to apply since you made this
patch atop the change that added the "5420" property, but you don't
reference that patch anywhere.  I also wouldn't have tagged this "ARM:
dts", since this doesn't actually update a "dts" file.  I'd probably
tag it "mmc: dw_mmc:".  You should probably re-spin for that.

Aside from that this looks fine to me.

Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux