On Thursday, August 29, 2013 12:45 PM, Pratyush Anand wrote: > On Wed, Aug 28, 2013 at 04:17:24PM +0800, Jingoo Han wrote: > > On Friday, August 23, 2013 5:36 PM, Pratyush Anand wrote: > > > On Fri, Aug 23, 2013 at 02:04:20PM +0800, Jingoo Han wrote: > > > > [...] > > > > #define MAX_PCIE_PORT_SUPPORTED 3 > > > static DECLARE_BITMAP(msi_irq_in_use[MAX_PCIE_PORT_SUPPORTED], > > > NUM_MSI_IRQS); > > > static unsigned int *msi_data[MAX_PCIE_PORT_SUPPORTED]; > > > > No, there is no need to do it. > > Without this, we can use 3 RCs by adding a node of 3rd RC to dt file. > > > > Yes, you can use RCs by adding nodes to dt file. But you will need one > msi_irq_in_use and one msi_data per RC (ie per port in this driver), isn't it? Aha, you're right. A few minutes ago, I found the same value of msi_data is used for 2 different RCs. It is my fault. As you mentioned, one msi_data per RC should be used. I will modify it in order to use one msi_data per RC. Thank you for your kind description. :-) Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
