Suman Anna <s-anna@xxxxxx> writes: > The WkupM3 mailbox used for triggering PM operations such as suspend > and resume on AM33x/AM43x is special in that the M3 processor cannot > access the mailbox registers. However, an interrupt is needed to be > sent to request the M3 to perform a desired PM operation. This patch > adds the support for this special mailbox through separate ops for > this mailbox. These ops are designed to have the WkupM3's Rx interrupt > programmed within the driver, during transmission of a message. The > message is immediately read back and the internal mailbox interrupt > acknowledged as well to avoid triggering any spurious interrupts to > the M3. > > Signed-off-by: Suman Anna <s-anna@xxxxxx> Dumb Q: why does all this extra logic belong in the mailbox driver and not in the wkup_m3 driver? To me, this seems like part of the IPC protocol between the MPU and M3 firmware, and not an inherent part of the AM33xx mbox. Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html