On 26-08-2013 00:42, Viresh Kumar wrote: > On 24 August 2013 04:45, Eduardo Valentin <eduardo.valentin@xxxxxx> wrote: >> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c >> index ad1fde2..ede6487 100644 >> --- a/drivers/cpufreq/cpufreq-cpu0.c >> +++ b/drivers/cpufreq/cpufreq-cpu0.c >> @@ -20,6 +20,9 @@ >> #include <linux/platform_device.h> >> #include <linux/regulator/consumer.h> >> #include <linux/slab.h> >> +#include <linux/thermal.h> >> +#include <linux/cpu_cooling.h> >> +#include <linux/cpumask.h> > > In alphabetical order please.. > OK. >> @@ -268,6 +272,13 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev) >> goto out_free_table; >> } >> >> + /* >> + * For now, just loading the cooling device; >> + * thermal DT code takes care of matching them. >> + */ >> + if (of_find_property(np, "cooling-zones", NULL)) >> + cdev = cpufreq_cooling_register(cpu_present_mask); > > Should we check if it passed or failed? And if failed Atleast flag an > appropriate message? > Yes, we need error checking code. I will add in next version. Thanks Kumar. > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Attachment:
signature.asc
Description: OpenPGP digital signature
