RE: [v3] powerpc/mpc85xx: Update the clock device tree nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> >
> >  	clockgen: global-utilities@e1000 {
> > -		compatible = "fsl,b4420-clockgen", "fsl,qoriq-clockgen-2.0";
> > +		compatible = "fsl,b4420-clockgen", "fsl,qoriq-clockgen-2.0",
> > +				   "fixed-clock";
> > +		clock-output-names = "sysclk";
> > +		#clock-cells = <0>;
> 
> Does U-Boot fill in clock-frequency here?
> 
Yes, clock-frequency will be filled by uboot.
You suggested we'd better not add it here.

> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		pll0: pll0@800 {
> > +			#clock-cells = <1>;
> > +			reg = <0x800>;
> > +			compatible = "fsl,core-pll-clock";
> > +			clocks = <&clockgen>;
> > +			clock-output-names = "pll0", "pll0-div2", "pll0-div4";
> > +		};
> > +		pll1: pll1@820 {
> > +			#clock-cells = <1>;
> > +			reg = <0x820>;
> > +			compatible = "fsl,core-pll-clock";
> > +			clocks = <&clockgen>;
> > +			clock-output-names = "pll1", "pll1-div2", "pll1-div4";
> > +		};
> 
> Please leave a blank line between properties and nodes, and between nodes.
> 
OK, will add.

> What does reg represent?  Where is the binding for this?
> 
> The compatible is too vague.
Reg is register offset. I should have had a binding document.
About the compatible, you should pointed it out earlier in SDK review.
It is too later to change since the clock driver is merged for months although 
I sent this patch first.
Besides, it is not too bad because other arch use the similar name.

Regards,
Yuantian

> 
> > +		mux0: mux0@0 {
> > +			#clock-cells = <0>;
> > +			reg = <0x0>;
> > +			compatible = "fsl,core-mux-clock";
> > +			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>,
> > +				 <&pll1 0>, <&pll1 1>, <&pll1 2>;
> > +			clock-names = "pll0_0", "pll0_1", "pll0_2",
> > +				"pll1_0", "pll1_1", "pll1_2";
> > +			clock-output-names = "cmux0";
> > +		};
> 
> What does reg represent?  Where is the binding for this?
> 
> The compatible is too vague.
> 
> -Scott

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux