Hi Darren, Thanks for the patch. On Fri, Aug 23, 2013 at 2:51 AM, Darren Etheridge <detheridge@xxxxxx> wrote: > Enhancing driver to enable probe triggered by a corresponding dt entry. > > Add da8xx-fb.txt documentation to devicetree section. > > Obtain fb_videomode details for the connected lcd panel using the > display timing details present in DT. > > Ensure that platform data is present before checking whether platform > callback is present (the one used to control backlight). So far this > was not an issue as driver was purely non-DT triggered, but now DT > support has been added this check must be performed. > > v2: squashing multiple commits from Afzal Mohammed (afzal@xxxxxx) > v3: remove superfluous cast > v4: expose both ti,am3352-lcdc and ti,da830-lcdc for .compatible > as driver can use enhanced features of all version of the > silicon block. > v5: addressed review comments from Prabhakar Lad > v6: Changed the .compatible naming to match the existing drm bindings > for am33xx devices > > Signed-off-by: Darren Etheridge <detheridge@xxxxxx> > --- > .../devicetree/bindings/video/da8xx-fb.txt | 42 ++++++++++++ > drivers/video/da8xx-fb.c | 66 +++++++++++++++++++- > 2 files changed, 105 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/video/da8xx-fb.txt > > diff --git a/Documentation/devicetree/bindings/video/da8xx-fb.txt b/Documentation/devicetree/bindings/video/da8xx-fb.txt > new file mode 100644 > index 0000000..575bb4b > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/da8xx-fb.txt > @@ -0,0 +1,42 @@ > +TI LCD Controller on DA830/DA850/AM335x SoC's > + > +Required properties: > +- compatible: > + DA830 - "ti,da8xx-tilcdc" > + AM335x SoC's - "ti,am33xx-tilcdc" what about DA850 ? Rest of the patch looks good, with that change you can add my, Acked-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
