于 2013年08月23日 03:55, Mark Brown 写道: > On Thu, Aug 22, 2013 at 12:34:53PM -0700, Brian Norris wrote: >> On Mon, Aug 19, 2013 at 12:10:01PM +0800, Huang Shijie wrote: > >> Why can't this be detected at runtime? We added a "no fast read" flag to >> the device table, so why not "dual/quad mode supported"? And believe it >> or not, not all m25p80 users have device tree. So it isn't very logical >> to tie this support to device-tree only. > Hi Brian: My only question here is do we need to add some flags , such as "quad read", to the device table? If you think we need to, i will add a patch for it. (Just as Brown said, when the DTS configurates the "m25p,quad-read" property, it means : Both the board and the NOR support the Quad read.) >> What you're really missing from device-tree (and the SPI subystem in >> general) is how to detect those SPI controllers which support dual and >> quad mode transfers, and how to communicate that a particular SPI >> transaction should be performed on 1 or 4 IO lines. We shouldn't have >> this just hacked in via assumptions. > That bit does need to be fixed in this driver, yes. The SPI core now > has quad mode support. yes, i do not need these bits in this driver. thanks Huang Shijie -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
