Re: [PATCH -next] mtd: atmel_nand: fix error return code in atmel_nand_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi, Wei Yongjun

On 8/23/2013 10:50 AM, Wei Yongjun wrote:
From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Thank you for catch this and
Acked-by: Josh Wu <josh.wu@xxxxxxxxx>

---
  drivers/mtd/nand/atmel_nand.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 65b302c..093bcf8 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -2047,6 +2047,7 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
  		irq = platform_get_irq(pdev, 0);
  		if (irq < 0) {
  			dev_err(host->dev, "Cannot get HSMC irq!\n");
+			res = irq;
  			goto err_nand_ioremap;
  		}

Best Regards,
Josh Wu
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux