On Thu, 2013-08-22 at 16:20 -0600, Stephen Warren wrote: > On 08/22/2013 10:30 AM, dinguyen@xxxxxxxxxx wrote: > > From: Dinh Nguyen <dinguyen@xxxxxxxxxx> > > > > "dw-apb-timer-osc" and "dw-apb-timer-sp" are the same implementation of the > > DW APB timer, just fed by different clocks. Thus, deprecate both > > "dw-apb-timer-osc" and "dw-apb-timer-sp" in lieu of "dw-apb-timer". > > The binding change looks reasonable to me. > > The *.dtsi change will cause the new DT not to work with older kernels > that don't support the new compatible values. Perhaps you're fine with that? I am okay with the older kernels not working as SOCFPGA is pretty new and older kernel don't really have too much support for it. > > I assume that the driver has already been updated to support the new > values, and that the driver change is guaranteed to be merged before > this change? Otherwise, git bisect will be broken for a while. Yes, the patch to update the driver was part of this series, but not merged yet. The driver's V1 patch was Acked-By: Jamie Iles who is the maintainer for Picoxcell and is the only other platform using this timer driver at the moment. The only changes since V1 is to maintain compatibility for the new binding values. Thanks, Dinh > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
