On 08/19/2013 11:54 PM, Jonathan Cameron wrote: > Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: >> On 08/16/2013 07:12 AM, Jacek Anaszewski wrote: >>> This patch adds device tree binding documentation >>> for the gp2ap020a00f proximity/als sensor. >> >>> diff --git a/Documentation/devicetree/bindings/iio/light/gp2ap020a00f.txt >>> +* Sharp GP2AP020A00F I2C Proximity/ALS sensor >>> + >>> +Required properties: >>> + >>> + - compatible : should be "sharp,gp2ap020a00f" >>> + - reg : the I2C address of the light sensor >>> + - interrupt-parent : phandle to the parent interrupt controller >>> + - interrupts : should be INT interrupt pin >>> + - vled-supply : VLED power supply, as covered >>> + in Documentation/devicetree/bindings/regulator/regulator.txt >> >> If this is a sensor for proximity and light, why does it need a >> regulator for an LED? > > This type of proximity sensor uses reflected light from an led right next to it to detect something is nearby. The devices typically either integrate the led directly or control an external led. OK, that makes sense. It might make sense to briefly describe this aspect of the HW at the top of the binding file. Perhaps something like: ---------- * Sharp GP2AP020A00F I2C Proximity/ALS sensor The proximity detector sensor requires an associated LED for its operation. The power supply to this LED is also defined by this binding. ---------- ? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
