RE: [PATCH v5 1/8] usb: phy: omap-control: Get rid of platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello Roger,

this will not work!

Roger Quadros wrote on 2013-08-20:

> -	struct omap_control_usb_platform_data *pdata =
> -			dev_get_platdata(&pdev->dev);
> +
> +	if (np) {
> +		of_property_read_u32(np, "ti,type", &control_usb->type);

here you are dereferencing control_usb

> +	} else {
> +		/* We only support DT boot */
> +		return -EINVAL;
> +	}
> 
>  	control_usb = devm_kzalloc(&pdev->dev, sizeof(*control_usb),
>  		GFP_KERNEL);

and here it is allocated!

Best Regards,
Thomas


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux