On Aug 16, 2013, at 5:55 PM, Stephen Warren wrote: > On 08/14/2013 01:09 PM, Kumar Gala wrote: >> Add driver for Qualcomm MSM Hardware Mutex block that exists on newer MSM >> SoC (MSM8974, etc). > >> diff --git a/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt b/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt > >> +Required properties: >> +- compatible: should be "qcom,tcsr-mutex" >> +- reg: Should contain registers location and length of mutex registers >> +- reg-names: >> + "mutex-base" - string to identify mutex registers >> +- qcom,num-locks: the number of locks/mutexes supported > > Doesn't the block support any interrupts? I suppose the interrupts > property can be optional though even if it does. No interrupts on the block. > Aside from the comments re: reg-names, this binding seems fine. > -- - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
