Hi, Thanks for the review. On 08/19/2013 11:18 PM, Stephen Warren wrote: > On 08/19/2013 05:40 AM, Andrzej Hajda wrote: >> max77693 mfd main device uses only wakeup field >> from max77693_platform_data. This field is mapped >> to wakeup-source common property in device tree. >> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt >> Optional properties: >> - regulators : The regulators of max77693 have to be instantiated under subnod >> named "regulators" using the following format. >> +- wakeup-source : Indicates if the device can wakeup the system from the sleep >> + state. > Does the property mean "can" or "should"? > > "Can" implies that the property means something about the HW. What > exactly does it mean; perhaps that some specific output pin of the chip > has been wired to an input IRQ/GPIO of the SoC or PMIC that (can) wake > up the system? If so, which pin, signal, ...? Also, doesn't this also > depend on the SoC itself supporting its input IRQ/GPIO as a wakeup > source, so isn't some co-ordination required between the SoC and chip, > such that this property doesn't mean "can wakeup the system", but simply > "a signal is routed to the SoC, so perhaps it can wakeup the system". > > "Should" implies policy, which probably shouldn't be represented in > device tree, since DT should describe the HW and not how it should be used. After short digging I have realized that "wakeup-source" property is already parsed by of_i2c_register_devices core function and it should not be parsed again by the driver itself. So I suppose the description of it can be removed from max77693 binding. Do you agree? Anyway I will prepare separate patch removing wakeup related code from probe and related field from max77693 platform_data - i2c_board_info::flag field should be used instead. > > Finally, if there was already a binding for max77693.txt, I don't think > the patch subject "added device tree support" is entirely accurate; this > change to the binding document seems to be more about adding a new > feature than adding DT support to the driver... > This patch really adds DT support to max77693 mfd driver :) The binding file which is already in kernel currently has no related code in the max77693 driver. I will add clarification in the commit message. Regards Andrzej -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
