Re: [PATCH 07/20] spi: spi-pxa2xx: remove legacy PXA DMA bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Aug 07, 2013 at 05:33:56PM +0200, Daniel Mack wrote:
> Generic DMA support was already implemented by commit cd7bed00
> ("spi/pxa2xx: break out the private DMA API usage into a separate
> file") which moved all the legacy PXA DMA implementation code into
> its own file.
> 
> With generic DMA available for PXA, we can now just trash this
> file.
> 
> Signed-off-by: Daniel Mack <zonque@xxxxxxxxx>
> Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
>  drivers/spi/Kconfig             |   9 +-
>  drivers/spi/Makefile            |   1 -
>  drivers/spi/spi-pxa2xx-pxadma.c | 490 ----------------------------------------
>  drivers/spi/spi-pxa2xx.h        |   6 +-
>  include/linux/spi/pxa2xx_spi.h  |   1 -
>  5 files changed, 2 insertions(+), 505 deletions(-)
>  delete mode 100644 drivers/spi/spi-pxa2xx-pxadma.c
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 89cbbab..219c346 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -316,16 +316,9 @@ config SPI_PPC4xx
>  	help
>  	  This selects a driver for the PPC4xx SPI Controller.
>  
> -config SPI_PXA2XX_PXADMA
> -	bool "PXA2xx SSP legacy PXA DMA API support"
> -	depends on SPI_PXA2XX && ARCH_PXA
> -	help
> -	  Enable PXA private legacy DMA API support. Note that this is
> -	  deprecated in favor of generic DMA engine API.
> -
>  config SPI_PXA2XX_DMA
>  	def_bool y
> -	depends on SPI_PXA2XX && !SPI_PXA2XX_PXADMA
> +	depends on SPI_PXA2XX

We should probably get rid of this Kconfig option entirely and always
compile the DMA engine support code with the driver.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux