Hi Stephen,
On Monday 12 August 2013 11:43:01 Stephen Warren wrote:
> On 07/25/2013 04:27 PM, Laurent Pinchart wrote:
> > Specify DT bindings for the TPU PWM controller and add OF support to the
> > driver.
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> > b/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> >
> > + - compatible: should be one of the following.
> > + - "renesas,tpu-r8a73a4": for R8A77A4 (R-Mobile APE6) compatible PWM
> > controller.
> > + - "renesas,tpu-r8a7740": for R8A7740 (R-Mobile A1) compatible PWM
> > controller.
>
> In the bindings I've seen, it's more typical for the compatible value to
> be ${vendor},${soc}-${unit} than ${vendor},${unit}-${soc}. I guess I
> don't know how common one format or the other is though.
I'm personally fine with both. However, when using a version number, the
format is ${vendor},${unit}-${version}. As we don't have an IP core version
number we use the SoC name instead, so ${vendor},${unit}-${soc} would make
sense. We should probably decide on one of the two alternatives and document
it.
> Other than that, the binding,
> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
