On Fri, Aug 16, 2013 at 11:20:55PM +0100, Grant Likely wrote:
> On Fri, Aug 16, 2013 at 10:55 PM, Thierry Reding
> <thierry.reding@xxxxxxxxx> wrote:
> > On Fri, Aug 16, 2013 at 02:06:37PM -0700, Greg Kroah-Hartman wrote:
> >> On Fri, Aug 16, 2013 at 10:39:21PM +0200, Thierry Reding wrote:
> >> > +static DEFINE_MUTEX(device_early_mutex);
> >> > +static LIST_HEAD(device_early_list);
> >> > +static bool device_is_early = true;
> >> > +
> >> > +/*
> >> > + * Keep a list of early registered devices so that they can be fully
> >> > + * registered at a later point in time.
> >> > + */
> >> > +static void device_early_add(struct device *dev)
> >>
> >> __init?
> >
> > Yes.
> >
> >> > +{
> >> > + mutex_lock(&device_early_mutex);
> >> > + list_add_tail(&dev->p->early, &device_early_list);
> >> > + mutex_unlock(&device_early_mutex);
> >> > +}
> >> > +
> >> > +/*
> >> > + * Mark the early device registration phase as completed.
> >> > + */
> >> > +int __init device_early_init(void)
> >> > +{
> >> > + device_is_early = false;
> >> > +
> >> > + return 0;
> >> > +}
> >> > +
> >> > +/*
> >> > + * Fixup platform devices instantiated from device tree. The problem is
> >> > + * that since early registration happens before interrupt controllers
> >> > + * have been setup, the OF core code won't know how to map interrupts.
> >> > + */
> >> > +int __init platform_device_early_fixup(struct platform_device *pdev)
> >>
> >> This shouldn't be in this file, because:
> >>
> >> > +/*
> >> > + * Fully register early devices.
> >> > + */
> >> > +int __init device_early_done(void)
> >> > +{
> >> > + struct device_private *private;
> >> > +
> >> > + list_for_each_entry(private, &device_early_list, early) {
> >> > + struct device *dev = private->device;
> >> > + int err;
> >> > +
> >> > + if (dev->bus == &platform_bus_type) {
> >>
> >> Why special case the platform bus? We are trying to move things off of
> >> the platform bus, don't make it harder to do that :)
> >
> > I heard about that, but I must have missed the thread where this was
> > discussed. Can you point me to it?
> >
> >> > + struct platform_device *pdev = to_platform_device(dev);
> >> > +
> >> > + err = platform_device_early_fixup(pdev);
> >> > + if (err < 0)
> >> > + dev_err(&pdev->dev,
> >> > + "failed to fixup device %s: %d\n",
> >> > + dev_name(&pdev->dev), err);
> >> > + }
> >>
> >> You should just have a bus callback that can be made here that, if
> >> present, can be called. That way any bus can handle this type of thing,
> >> not just the platform one.
> >
> > You mean something like an .early_fixup() in struct bus_type? That would
> > indeed be much cleaner. As I mentioned this is a very early prototype
> > and this particular hunk exists specifically to fixup the platform
> > devices created by the device tree helpers so that the kernel actually
> > boots to the login prompt.
> >
> >> Not that I really like the whole idea anyway, but I doubt there's much I
> >> can do about it...
> >
> > Well, getting feedback from you and others is precisely the reason why I
> > wanted to post this early. There must be a reason why you don't like it,
> > so perhaps you can share your thoughts and we can mould this into
> > something that you'd be more comfortable with.
> >
> > To be honest I don't particularly like it either. It's very hackish for
> > core code. But on the other hand there are a few device/driver ordering
> > problems that this (or something similar) would help solve. I'm
> > certainly open to discuss alternatives and perhaps there's a much
> > cleaner way to solve the problem.
>
> And on that note, I think we're all in agreement that it's ugly!
> Looking at it now, I don't think it is the right approach.
>
> In the big scheme of things, there really aren't a lot of devices that
> will need this functionality. Something I don't have a good handle on
> is the set of devices needed to be created early. Yes, some of the
> clocks and power rails need to be set up, but do all of them? Yes, the
> interrupts need to be set up, but was of_irq_init() a mistake?
> Cascaded interrupt controllers really could be normal devices if there
> isn't anything critical for early boot connected to them (ie. the
> timer). If irq references were changed to be parsed at .probe() time
> instead of device registration time, the deferred probe would have
> everything needed to make sure the interrupt controllers get probed
> before the users.
I remember having this discussion with you before. Deferred probing was
one solution to the problem at the time. However as you point out the
resolution of IRQ references isn't handled by deferred probing, and
supposedly is one of the reasons why interrupt chips are now registered
early using of_irq_init(), which, as I understand it, is the modern-day
equivalent of doing this in drivers/ rather than by platform- or board-
setup code in arch/.
While I'm totally in favour of postponing the resolution of interrupt
references to .probe() time, I also think it's unrealistic to require
individual drivers to do it explicitly. I think it's something that the
core should (and can) solve.
If you nor anyone else has any objections I'll take a stab at it, see if
I can come up with something that solves this nicely. Even if it doesn't
solve everything, it would at least eliminate one of the problems that
currently require the of_irq_init() workarounds.
The common clock framework provides of_clk_init() for similar purposes,
though I'm not sure if the same arguments can be applied to it.
> Also, for the devices that are created early, is it really appropriate
> to use APIs that require a struct device? I could easily argue that
> anything done at early boot should only be the bare minimum to allow
> the kernel to get to initcalls, and so mucking about with devices is
> inappropriate because it really messes with the assumptions made in
> the design of the driver model.
I see your point. But perhaps this could be solved by allowing drivers
to register something like an .early_probe() (or perhaps .of_probe()),
which would be called early to set up the bare minimum to continue to
boot. That's probably not easy to do because drivers are usually only
registered much later too. One solution to that particular problem may
be to move the early probe function to a separate early driver struct.
Thinking about it, that's probably not a whole lot better than what we
currently have. But it would at least somewhat restore consistency in
that the same source file could provide the early driver and a regular
driver so that at least for the full driver the devices would behave
normally.
There could even be some sort of hand-off between the early and the full
driver, though I doubt that it would be necessary. If the early setup is
really only the bare minimum then that code should restrict itself to
writing hardware registers and not set up any long-lived data structures
and whatnot.
Thierry
Attachment:
pgp3NMPlHaYjy.pgp
Description: PGP signature
