On 08/17/2013 12:52 AM, Stephen Warren wrote: > On 08/15/2013 07:13 AM, Sebastian Andrzej Siewior wrote: >> This prefix is currently used for the musb driver. > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > >> +mg Mentor Graphics > > It's slightly short; I would have preferred "mentor" I think. but I > guess it's fine. > > I see that both values are already used though: > >> arch/arm/boot/dts/am33xx.dtsi:375: compatible = "mg,musbmhdrc"; >> arch/arm/boot/dts/am33xx.dtsi:430: compatible = "mg,musbmhdrc"; > >> arch/arm/boot/dts/dbx5x0.dtsi:181: "mentor,musb"; > > Should both be documented? Should the bindings for those devices be > unified on one vendor prefix, with the old one perhaps still documented > as deprecated depending on how long it's been around? I wasn't aware of the dbx5x0 mentor,usb binding. As far as the am33xx is concerned, it has been prepared for the next merge window and can be changed. However the mentor,usb binding isn't documented either. It is added in addition to stericsson,db8500-musb. The way the musb core works is that you require a glue layer. That means the mentor,musb binding isn't used by a driver either. I modeled the binding after the current driver design where you have a platform device around the mentor device. So the am335x usb device gets probed and creates a platform device for the musb device. The binding as-it isn't used either, it is just there not have a node without a compatible property. Not I see that there is a dr_mode property which I could use instead the old ti,port-mode. Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
