On Fri, Aug 16, 2013 at 12:11:51PM +0200, Sascha Hauer wrote: > > Some clocks are not from CCM and we haven't defined in imx6q-clk.txt, > > so in most cases we can't provide a phandle for them, eg: spdif_ext. > > I think it's a bit hard to force it to be 'required'. An 'optional' > > looks more flexible to me and a default one is ensured even if it's > > missing. > > <&clks 0> is the dummy clock. This can be used for all input clocks not > defined by the SoC. That's feasible, thank you. > spdif_ext would be a fixed clock on boards which provide it, but wiring > this up would be the job of the board maintainer. Understood. > Look, it's really simple. Define the binding in a way that describes the > hardware. Then use some sensible default in the driver for which clock > to use. This doesn't have to cover all possible usecases, it only has > to work. This is all that is necessary to get this driver mainline and > will make most users happy. Then, later, someone might come along who > needs more fine grained control over the clocks, but this guy is then > able to justify *why* more control is needed. > > This is not about getting a full featured driver into mainline. Get > a basic driver into mainline and improve it later. You'll make it > easier for us all. Thank you for explain all these to the despicable me. I'll try to make myself more comfortable with rules here. Best regards, Nicolin Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
