On Wed, 2013-08-14 at 15:21 -0700, Russ Dill wrote: > > The CM3 driver needs to figure out where the core regulator is connected > > using using either DT or the regulator framework and ask the TPS (via a > > new interface) for register writes for sleep/wake sequences. Then those > > sequences will actually match the correct voltages configured using > > DT/DVFS. > > That seems like it'd add a lot of complexity to the regulator > subsystem, as well as all the PMIC and other I2C regulators that any > users of these device tree properties may end up using for not a lot > of gain. There would be two separate code paths for any used > I2C regulator or PMIC for setting voltages. Yes, it would be additional complexity, but it would avoid duplicating information which is already in the DT (location&address of the PMIC, type of pmic) and in the kernel (how to program voltages for a given regulator). As DT is supposed to describe the hardware, duplicate information should be unnecessary. One different way to look at this is that the CM3 firmware is a separate consumer of the DT. DT being OS-indepentent, the CM3 firmware should be able to get all the information it needs from the DT (maybe with help from the CM3 driver). Regards, Jan -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html