On 08/09/2013 03:53 AM, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" <iivanov@xxxxxxxxxx> > > MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) > and HS, SS PHY's controll and configuration registers. s/controll/control/ > It could operate in device mode (SS, HS, FS) and host > mode (SS, HS, FS, LS). > diff --git a/Documentation/devicetree/bindings/usb/msm-ssusb.txt b/Documentation/devicetree/bindings/usb/msm-ssusb.txt > +MSM SuperSpeed DWC3 USB SoC controller > + > +Required properities : > +- compatible : sould be "qcom,dwc3-hsphy"; ... > +Required properities : > +- compatible : sould be "qcom,dwc3-ssphy"; I would expect different compatible values to be documented in different files. > +Optional properties : > +- gdsc-supply : phandle to the globally distributed switch controller > + regulator node to the USB controller. Which of the 3 compatible values that were described above is that property optional for? > +Sub nodes: > +- Sub node for "DWC3 USB3 controller". > + This sub node is required property for device node. The properties > + of this subnode are specified in dwc3.txt. Why not represent the PHY and USB controller as separate top-level nodes? They can point at each-other with phandles if they need to know each-others' identity. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html