Hello, Sorry. I still don't understand what checksum has to do with it. Does GRO depends on Rx/Tx checksum ? I don't think so. In the napi_gro_receive() we check that the device supports NETIF_F_GRO, but I don't see that we inspect checksum or that NETIF_F_GRO is depends on checksum. Can you please explain how checsum offload is related ? rgs David On Tue, Aug 13, 2013 at 9:29 AM, Julia Lawall <julia.lawall@xxxxxxx> wrote: > On Tue, 13 Aug 2013, Francois Romieu wrote: > >> Julia Lawall <julia.lawall@xxxxxxx> : >> > François Romieu <romieu@xxxxxxxxxxxxx> : >> [...] >> > > Can you send a netif_receive_skb replacement patch for it ? >> > >> > Just to be sure, I just replace netif_rx by netif_receive_skb, nothing >> > else? >> >> Yes. It should imho be fine with a comment incluing your analysis and a >> few words about the current state of checksum offloading support. > > I wouldn't know what to say about the checksum part. It is not supported > so I should use netif_receive_skb? > > thanks, > julia -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
