On 08/12/2013 04:17 AM, Kishon Vijay Abraham I wrote: > From: Felipe Balbi <balbi@xxxxxx> > > Without this node, there will be no palmas > driver to notify dwc3 that a cable has > been connected and, without that, dwc3 > will never initialize. > diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts > interrupt-controller; > #interrupt-cells = <2>; > > + extcon_usb3: palmas_usb { > + compatible = "ti,palmas-usb"; This isn't so much a comment on this patch as the Palmas binding: Presumably, the Palmas device contains a USB VID detector, not a whole USB controller. I'd expect the compatible value to indicate this more directly, i.e. be something like ti,palmas-usb-vid or ti,palmas-usb-vid-detector. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html