Re: [PATCH] drivers/rtc/rtc-palmas.c: rename charging dt property name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Friday 09 August 2013 09:07 PM, Kumar Gala wrote:
On Aug 9, 2013, at 10:47 AM, Laxman Dewangan wrote:

Renaming the charging property names to have more meaningful:

Renaming property "ti,back-battery-charge-enable" to "ti,backup-battery-chargeable"
to tells OS that attahced battery is chargeable and OS can do charging.

Renaming property "ti,back-battery-charge-low-current" to
"ti,backup-battery-charge-high-current" for safe configuration as maximum charging current
of battery depends on battery type and overcurrent charging can damage the battery. So
enable the high current charging only if this property is available.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
---
The patch V4 version of the change
[PATCH V4] drivers/rtc/rtc-palmas.c: support for backup battery charging
is already applied but still the discussion is going on the property name.

To correct the property name, I am sending this patch on top of above patch
as per discussion on above patch.

.../devicetree/bindings/rtc/rtc-palmas.txt         |   21 +++++++++++--------
drivers/rtc/rtc-palmas.c                           |   14 ++++++------
2 files changed, 19 insertions(+), 16 deletions(-)
Are you not concerned about any dts with the old property names being around such that the code should support the old name as well?


I introduced these properties on above patch and it applied yesterday only. Hence no one is using now. So no issue here.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux