Hi Julius, On Thursday 08 of August 2013 11:06:54 Julius Werner wrote: > > I'm not sure I understand. The old documentation referred to the > > USBDEVICE_PHY_CONTROL and USBHOST_PHY_CONTROL registers for a phy, and > > your new version only refers to (usb device) PHY_CONTROL. Regardless > > of > > multiple phys, you're suggesting that we describe less of each phy. > > That seems like taking away usable information. Unless I've > > misunderstood? > > Well that's just the thing that's confusing right now, and which I am > trying to fix: every PHY is either DEVICE or HOST and thus has only > one PMU register. The current code describes the PMU register space > for all PHYs on the system in the DT entry of every PHY and then > calculates which register to use with hardcoded offsets. I think it > makes much more sense if every PHY only describes its own register and > doesn't need to do address arithmetic later on. > > As Vivek said there is one exception in an old Exynos4, Not that old yet. :) > but that is > currently not implemented in the upstream kernel anyway Sorry, I don't understand what is not implemented. Without your patch, the PHY driver handles both PMU registers of Exynos4. Best regards, Tomasz > , and if it > ever will be it's still much easier to special case one weird chip > than to have a super complicated and confusing mechanism for all of > them. > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
