On Fri, Jul 26, 2013 at 7:36 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 07/26/2013 04:15 AM, Laxman Dewangan wrote: >> Some of pincontrol driver needs the utility function to create map >> list. The utility function needed for adding mux, configs etc. It is a noble goal to unify this and thank you *very* much for taking it on. > Which other drivers already contain this code? Are you planning on > converting them over to use these new functions? The code looks > familiar, so I assume it's just cut/paste from Tegra with some renames, > so I didn't read it through in detail. > >> drivers/pinctrl/pinconf-generic.c | 105 +++++++++++++++++++++++++++++++ >> include/linux/pinctrl/pinconf-generic.h | 52 +++++++++++++++ > > I don't think those are the correct files for this code. Presumably > there's no reason at all why a pinctrl driver that doesn't require > CONFIG_GENERIC_PINCONF can't use these basic utility functions. Perhaps > add a new pinctrl-utils file? Agree with Stephen, we need to put this in a separate file, such at pinctrl-dt.c or just put it into core.c. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
