Re: [PATCH] ASoC: dt: Move WM8903 pin list from Tegra board binding to CODEC binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Aug 07, 2013 at 10:02:12AM -0600, Stephen Warren wrote:
> On 08/07/2013 03:16 AM, Mark Brown wrote:
> > From: Mark Brown <broonie@xxxxxxxxxx>

> > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-wm8903.txt b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-wm8903.txt
> 
> >    the second being the connection's source. Valid names for sources and
> ...
> > +  sinks are the WM8903's pins (documented in the WM8903 binding document),
> > +  and the jacks on the board:

> >    Board connectors:

> Probably want to remove the line "Board connectors:" ?

The board is still defining some jacks.

> > diff --git a/Documentation/devicetree/bindings/sound/wm8903.txt b/Documentation/devicetree/bindings/sound/wm8903.txt

> > +Pins on the device (for linking into audio routes):
> > +
> > +  * IN1L
> > +  * IN1R

> I thought all the pins were going to be assigned numbers too so that
> bindings could use either?

I think someone who wants to start using those should get to pick
numbers they find pleasing :)  More to the point it's more effort and
I'd like to see it in action to see the nicest way to write it up -
create a header and refer to it or just put it in the docs and have the
numbers assigned with new DAPM widget types embedding the numbers for
example?

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux