Hi Arun, On 4 August 2013 20:30, Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> wrote: > Hi Arun, > > On 08/02/2013 05:02 PM, Arun Kumar K wrote: >> >> This patch adds the crucial hardware pipeline control for the >> fimc-is driver. All the subdev nodes will call this pipeline >> interfaces to reach the hardware. Responsibilities of this module >> involves configuring and maintaining the hardware pipeline involving >> multiple sub-ips like ISP, DRC, Scalers, ODC, 3DNR, FD etc. >> >> Signed-off-by: Arun Kumar K<arun.kk@xxxxxxxxxxx> >> Signed-off-by: Kilyeon Im<kilyeon.im@xxxxxxxxxxx> >> --- >> .../media/platform/exynos5-is/fimc-is-pipeline.c | 1961 >> ++++++++++++++++++++ >> .../media/platform/exynos5-is/fimc-is-pipeline.h | 129 ++ >> 2 files changed, 2090 insertions(+) >> create mode 100644 drivers/media/platform/exynos5-is/fimc-is-pipeline.c >> create mode 100644 drivers/media/platform/exynos5-is/fimc-is-pipeline.h [snip] >> + setfile_name,&is->pdev->dev); >> + if (ret != 0) { >> + pr_err("Setfile %s not found\n", setfile_name); > > > dev_err(), please. I'm a bit tired of commenting on this excessive pr_* > usage. Please really make sure dev_err()/v4l2_err() is used where possible. pr_* should be used only when device pointer is not available. In all other cases dev_* takes priority. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html