Re: [RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2 August 2013 20:32, Arun Kumar K <arun.kk@xxxxxxxxxxx> wrote:
> From: Shaik Ameer Basha <shaik.ameer@xxxxxxxxxxx>
>
> This patch adds support for media device for EXYNOS5 SoCs.
> The current media device supports the following ips to connect
> through the media controller framework.
>
> * MIPI-CSIS
>   Support interconnection(subdev interface) between devices
>
> * FIMC-LITE
>   Support capture interface from device(Sensor, MIPI-CSIS) to memory
>   Support interconnection(subdev interface) between devices
>
> * FIMC-IS
>   Camera post-processing IP having multiple sub-nodes.
>
> G-Scaler will be added later to the current media device.
>
> The media device creates two kinds of pipelines for connecting
> the above mentioned IPs.
> The pipeline0 is uses Sensor, MIPI-CSIS and FIMC-LITE which captures
> image data and dumps to memory.
> Pipeline1 uses FIMC-IS components for doing post-processing
> operations on the captured image and give scaled YUV output.
>
> Pipeline0
>   +--------+     +-----------+     +-----------+     +--------+
>   | Sensor | --> | MIPI-CSIS | --> | FIMC-LITE | --> | Memory |
>   +--------+     +-----------+     +-----------+     +--------+
>
> Pipeline1
>  +--------+      +--------+     +-----------+     +-----------+
>  | Memory | -->  |  ISP   | --> |    SCC    | --> |    SCP    |
>  +--------+      +--------+     +-----------+     +-----------+
>
> Signed-off-by: Shaik Ameer Basha <shaik.ameer@xxxxxxxxxxx>
> Signed-off-by: Arun Kumar K <arun.kk@xxxxxxxxxxx>

[snip]

> +
> +Common 'camera' node
> +--------------------
> +
> +Required properties:
> +
> +- compatible   : must be "samsung,exynos5-fimc", "simple-bus"

I am not sure if this point was discusssed during the previous
versions. "samsung,exynos5-fimc" seems a bit generic.
The compatible string should generally point to a specific SoC (the
first one to have this IP), something like "samsung,exynos5250-fimc".

> +- clocks       : list of clock specifiers, corresponding to entries in
> +                 the clock-names property;
> +- clock-names  : must contain "sclk_cam0", "sclk_cam1" entries,
> +                 matching entries in the clocks property.
> +

[snip]

> +Example:
> +
> +       aliases {
> +               fimc-lite0 = &fimc_lite_0
> +       };
> +
> +       /* Parallel bus IF sensor */
> +       i2c_0: i2c@13860000 {
> +               s5k6aa: sensor@3c {
> +                       compatible = "samsung,s5k6aafx";
> +                       reg = <0x3c>;
> +                       vddio-supply = <...>;
> +
> +                       clock-frequency = <24000000>;
> +                       clocks = <...>;
> +                       clock-names = "mclk";
> +
> +                       port {
> +                               s5k6aa_ep: endpoint {
> +                                       remote-endpoint = <&fimc0_ep>;
> +                                       bus-width = <8>;
> +                                       hsync-active = <0>;
> +                                       vsync-active = <1>;
> +                                       pclk-sample = <1>;
> +                               };
> +                       };
> +               };
> +       };
> +
> +       /* MIPI CSI-2 bus IF sensor */
> +       s5c73m3: sensor@0x1a {

0x not needed.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux