From: Sean Cross [mailto:xobs@xxxxxxxxxx] Data: Monday, August 05, 2013 10:24 AM > > > +Example: > > > + &enet { > > > + micrel,clk-control-pad-skew = <0xf0f0>; micrel,rx-data-pad-skew = > > > +<0x0000>; micrel,tx-data-pad-skew = <0xffff>; status = "okay"; > > > +}; > > > + > > > > > > > > The phy binding must be the phy node, not the ethernet node. > > Pls refer to: > > Documentation/devicetree/booting-without-of.txt > > Documentation/devicetree/bindings/net/phy.txt > > This won't necessarily work. In my board, I don't think it's possible to > manually specify the PHY, as most of the fields required by the OF PHY > node don't apply to this device (at least according to phy.txt). There > are no interrupts, no interrupt parent, and it's unclear what the reg or > linux,phandle fields do. All of these are required fields, none of which > seem to apply to this particular board. Furthermore, it doesn't seem to > be possible to specify a particular PHY, such as the ksz9021. > > I see the pattern of getting OF settings from a parent's node used > elsewhere in the kernel. For example, in mmc_of_parse(), or more > similarly in the chipidea ci_hdrc_probe() driver. Yes, the patch is only reasonable for your platform, but it is the phy driver for different platforms that you must considerate. Please add more example cases in binding doc. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
