On 10/11/2023 05:32, Yi Chou wrote: > The necessary fields to initialize the widevine related functions in > OP-TEE. > > Signed-off-by: Yi Chou <yich@xxxxxxxxxxxx> > Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx> > > --- Please provide version log and proper background for this patch. This was already sent to Linux kernel, so we should not spend time to figure it out. > There's no plan to add more optee stuff now. > This is it. > > dtschema/schemas/options/op-tee/widevine.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 dtschema/schemas/options/op-tee/widevine.yaml > > diff --git a/dtschema/schemas/options/op-tee/widevine.yaml b/dtschema/schemas/options/op-tee/widevine.yaml > new file mode 100644 > index 0000000..925c214 > --- /dev/null > +++ b/dtschema/schemas/options/op-tee/widevine.yaml Missing vendor prefix - google, > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/options/op-tee/widevine.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Google Widevine initialization parameters What is Widevine? You write it once "widevine", once "Widevine" but never explain what it is. > + > +maintainers: > + - Jeffrey Kardatzke <jkardatzke@xxxxxxxxxxxx> > + - Yi Chou <yich@xxxxxxxxxxxx> > + > +description: > + The necessary fields to initialize the widevine related functions in > + OP-TEE. This node does not represent a real device, but serves as a > + place for passing data between firmware and OP-TEE. > + > +properties: > + google,optee-hardware-unique-key: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + maxItems: 32 > + description: | > + The hardware-unique key of the Widevine OP-TEE. It will be used > + to derive the secure storage key. > + For more information, please reference: > + https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html#hardware-unique-key Blank line > + google,tcg-tpm-auth-public-key: Missing tcg prefix as asked by Rob. > + $ref: /schemas/types.yaml#/definitions/uint8-array > + maxItems: 1024 > + description: | > + The TPM auth public key. Used to communicate the TPM from OP-TEE. > + The format of data should be TPM2B_PUBLIC. > + For more information, please reference the 12.2.5 section: > + https://trustedcomputinggroup.org/wp-content/uploads/TCG_TPM2_r1p59_Part2_Structures_pub.pdf Blank line > + google,widevine-root-of-trust-ecc-p256: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + maxItems: 32 > + description: | > + The Widevine root of trust secret. Used to sign the widevine > + request in OP-TEE. The value is an ECC NIST P-256 scalar. > + For more information, please reference the G.1.2 section: > + https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-186.pdf Blank line > +required: > + - google,optee-hardware-unique-key > + - google,tcg-tpm-auth-public-key > + - google,widevine-root-of-trust-ecc-p256 > + > +additionalProperties: false > + > +examples: > + - | > + options { > + widevine { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + google,optee-hardware-unique-key = [ > + 12 f7 98 d2 0e d2 85 92 a5 82 bf 98 b8 99 2b c0 > + c6 6f 19 85 79 86 65 18 55 eb ff 9b 6c c0 ac 27 > + ]; > + google,tcg-tpm-auth-public-key = [ > + 00 76 00 23 00 0b 00 02 04 b2 00 20 e1 47 bf 27 > + e1 74 30 c8 16 ab 72 4d 5c 77 e1 5c 61 2d 56 81 > + b3 35 cd 9d eb 67 41 37 69 f0 32 41 00 10 00 10 > + 00 03 00 10 00 20 70 9a df 50 f9 0f d5 f4 40 e0 > + ea 2c e8 f2 26 9f 0e 5c 02 70 16 c3 6c c1 83 03 > + 2d 04 10 bd 85 7a 00 20 83 03 c2 66 6e 01 32 34 > + 5c 5e 80 22 c7 48 24 3c 70 6b b8 e4 24 42 74 a9 > + cf fc ab f8 30 e9 de 51 > + ]; > + google,widevine-root-of-trust-ecc-p256 = [ > + ac 0d 86 c3 d7 b5 b7 a2 6f c3 d9 93 f7 de bc bb > + d5 c4 25 9b 21 5f 36 af b5 dd 6d 29 9d 08 c0 10 > + ]; > + }; > + }; Best regards, Krzysztof
