On Tue, Jul 25, 2023 at 8:52 AM Simon Glass <sjg@xxxxxxxxxxxx> wrote: > > On Mon, 24 Jul 2023 at 04:02, Yi Chou <yich@xxxxxxxxxxxx> wrote: > > > > Sorry for the late reply, > > this is the new version that moved the bindings to the /options node. > > > > From 1662ec6c6a9cbb07d83157ad9411897b4acaf1f0 Mon Sep 17 00:00:00 2001 > > From: Yi Chou <yich@xxxxxxxxxx> > > Date: Wed, 14 Jun 2023 14:49:46 +0800 > > Subject: [PATCH] dt-bindings: Add Google Widevine initialize parameters > > > > The necessary fields to initialize the widevine related functions in > > OP-TEE. > > > > Change-Id: Iceb6c533bcb60034e811d4fdf9310d9df48507de > > Signed-off-by: Yi Chou <yich@xxxxxxxxxx> > > --- > > .../bindings/options/google,widevine.yaml | 61 +++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/options/google,widevine.yaml > > > > diff --git a/Documentation/devicetree/bindings/options/google,widevine.yaml > > b/Documentation/devicetree/bindings/options/google,widevine.yaml > > new file mode 100644 > > index 0000000000000..acfc96d162c88 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/options/google,widevine.yaml > > @@ -0,0 +1,61 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/options/google,widevine.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Google Widevine initialize parameters. > > + > > +maintainers: > > + - Jeffrey Kardatzke <jkardatzke@xxxxxxxxxxxx> > > + - Yi Chou <yich@xxxxxxxxxxxx> > > + > > +description: > > + The necessary fields to initialize the widevine related functions in > > + OP-TEE. This node does not represent a real device, but serves as a > > + place for passing data between firmware and OP-TEE. > > + > > +properties: > > + compatible: > > + const: google,widevine > > + > > + huk: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + The encryption key of the Widevine OP-TEE storage. > > + > > + tpm-auth-pk: > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + The TPM auth public key. Used to communicate the TPM from OP-TEE. > > Can you add more details about this key. What format is it in? How is > it created? > > > + > > + widevine-dice: > > We should avoid the 'widevine-' prefix since it is already this node. Yes, but then 'dice' is pretty vague. It is preferred that property names are unique enough to only have 1 type globally (at least within a defined size). This allows using the schemas to decode DT data. > > I don't know what the words mean in the description, so I cannot offer > a better idea. > > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + The Widevine boot certificate chain(Device Identifier Composition > > + Engine) of this device. Used to provision the device status with > > + the Widevine server in OP-TEE. > > Ditto > > > + > > + widevine-ta-key: > > As above > > + $ref: /schemas/types.yaml#/definitions/string > > + description: > > + The Widevine private key corresponding to the widevine-dice. > > + Used to signing the widevine request in OP-TEE. > > Again, more details please > > > + > > +required: > > + - compatible What's the point of this binding if none of the other properties are required? > > + > > +additionalProperties: false > > + > > +examples: > > + - |+ > > + options { > > + widevine: { > > + compatible = "google,widevine"; > > + > > + huk = [00 de ad be af aa bb cc], > > + tpm-auth-pk = [00 de ad be af aa bb cc], > > + widevine-dice = [00 de ad be af aa bb cc], > > + widevine-ta-key = [00 de ad be af aa bb cc], > > + }; > > + }; > > -- > > 2.39.2 > > > > [..] > > Regards, > Simon
