On Thu, Jun 17, 2021 at 04:24:12PM -0600, Rob Herring wrote: > On Thu, Jun 17, 2021 at 1:19 PM Simon Glass <sjg@xxxxxxxxxxxx> wrote: > > > > Hi Rob, > > > > On Mon, 14 Jun 2021 at 11:36, Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > > Travis-ci.org is going away and moving to Travis-ci.com requires some > > > work. It would probably involve fixing authentication issues yet again. > > > Instead, let's just move to a GH actions job which is fairly trivial to > > > setup. This has the side benefit of CI will run on anyone's fork without > > > further setup. > > > > > > As part of this, the specification file name gains a 'git-describe' > > > based version number. > > > > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > > --- > > > .github/workflows/ci.yml | 60 ++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 60 insertions(+) > > > create mode 100644 .github/workflows/ci.yml > > > > Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx> > > Thanks for looking. > > > > > Questions below > > > > > > > > diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml > > > new file mode 100644 > > > index 000000000000..f8fe08d52cb0 > > > --- /dev/null > > > +++ b/.github/workflows/ci.yml > > > @@ -0,0 +1,60 @@ > > > +name: Github Action CI > > > + > > > +on: > > > + push: > > > + branches: > > > + - '*' > > > + tags: > > > + - 'v*' > > > + pull_request: > > > + branches: > > > + master > > > + > > > +jobs: > > > + build: > > > + runs-on: ubuntu-latest > > > + > > > + steps: > > > + - uses: actions/checkout@v2 > > > + with: > > > + fetch-depth: 0 > > > + > > > + - name: install > > > + run: | > > > + sudo apt-get update > > > + sudo apt-get install latexmk libalgorithm-diff-perl texlive texlive-latex-extra texlive-humanities graphviz > > > + pip3 install --user mako > > > + pip3 install --user typing > > > + pip3 install --user Sphinx > > > > Does this need the capital S ? > > I believe so. This is copy-paste from the TravisCI job. > > > Can we use apt install instead? > > Perhaps. I think the issue here was the TravisCI using ancient ubuntu > versions and we needed a newer version of Sphinx at some point. GH is > the latest LTS, so it should be new enough. On a slight tangent, perhaps a requirements.txt so that in CI you just: pip3 install --user --requirement path/to/requirements.txt and as a bonus it documents what modules someone needs to build outside of CI and future module needs are handled without a CI change. -- Tom
Attachment:
signature.asc
Description: PGP signature
