Re: [PATCH] Add note about the initial character in a compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Rob Herring <robh@xxxxxxxxxx> writes:

> On Mon, May 17, 2021 at 9:25 AM Bolivar, Marti
> <Marti.Bolivar@xxxxxxxxxxxxx> wrote:
>>
>> Commit 05a34819e5 ("Add more restrictions on compatible strings")
>> started to add recommendations on the contents of compatible strings.
>>
>> Add an additional recommendation that compatibles should start with a
>> letter. In particular, this matches what dt-schema is doing.
>>
>> Signed-off-by: Martí Bolívar <marti.bolivar@xxxxxxxxxxxxx>
>> ---
>>  source/chapter2-devicetree-basics.rst | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> I can't get this to apply. I'm not really sure what the issue is, but
> can you resend without base64 encoding or send a GH PR.

Sorry about that. I used git send-email, but I have to jump through some
hoops to get through the corp email servers and I'm guessing there's an
issue somewhere along the way.

I sent a PR:

https://github.com/devicetree-org/devicetree-specification/pull/44

Thanks for leaving that door open.

Martí

>
>>
>> diff --git a/source/chapter2-devicetree-basics.rst b/source/chapter2-devicetree-basics.rst
>> index fa39625..40be221 100644
>> --- a/source/chapter2-devicetree-basics.rst
>> +++ b/source/chapter2-devicetree-basics.rst
>> @@ -484,9 +484,9 @@ Description:
>>     (such as a stock ticker symbol), and ``model`` specifies the model
>>     number.
>>
>> -   The compatible string should consist only of lowercase letters, digits
>> -   and dashes. A single comma is typically only used following a vendor
>> -   prefix. Underscores should not be used.
>> +   The compatible string should consist only of lowercase letters, digits and
>> +   dashes, and should start with a letter. A single comma is typically only
>> +   used following a vendor prefix. Underscores should not be used.
>>
>>  Example:
>>
>> --
>> 2.31.1




[Index of Archives]     [Device Tree]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]

  Powered by Linux