Re: [PATCH 1/3] Clarify language on /memreserve/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 9/15/20 7:04 PM, Grant Likely wrote:
> The language was ambiguous. Rephrase and reformat to be more readable.
>
> Co-authored-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>
> Signed-off-by: Grant Likely <grant.likely@xxxxxxx>
> Cc: Heinrich Schuchardt <xypron.glpk@xxxxxx>
> ---
>  source/chapter6-source-language.rst | 20 ++++++++++++++------
>  1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/source/chapter6-source-language.rst b/source/chapter6-source-language.rst
> index ed4e234..295fcd6 100755
> --- a/source/chapter6-source-language.rst
> +++ b/source/chapter6-source-language.rst
> @@ -233,15 +233,23 @@ File layout
>              [child nodes]
>          };
>
> -The /dts-v1/; shall be present to identify the file as a version 1 DTS
> +``/dts-v1/;`` shall be present to identify the file as a version 1 DTS
>  (dts files without this tag will be treated by dtc as being in the
>  obsolete version 0, which uses a different format for integers in
>  addition to other small but incompatible changes).
>
> -Memory reservations define an entry for the devicetree blob’s memory
> -reservation table. They have the form: e.g., /memreserve/ <address>
> -<length>; Where <address> and <length> are 64-bit C-style integers.
> +Memory reservations (see section :ref:`sect-fdt-memory-reservation-block`)
> +are represented by lines in the form::
>
> -*  The / { }; section defines the root node of the devicetree.
> +   /memreserve/ <address> <length>;
>
> -*  C style (/* ... \*/) and C++ style (//) comments are supported.
> +Where ``<address>`` and ``<length>`` are 64-bit C-style integers, e.g.,
> +
> +.. code-block:: dts
> +
> +   /memreserve/ 0x10000000 0x0004000;

+   /memreserve/ 0x10000000 0x00004000;

The 28bit number looks strange here. Let's add another zero so that the
number formats match (or remove the leading zeros).

Best regards

Heinrich

> +
> +The ``/ { ... };`` section defines the root node of the devicetree, and
> +all the device tree data is contained within it.
> +
> +C style (``/* ... \*/``) and C++ style (``//``) comments are supported.
>





[Index of Archives]     [Device Tree]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]

  Powered by Linux