Re: [PATCH] meta-schemas: interrupts: allow interrupt-controller nodes to be objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi,

On Mon, Jun 10, 2019 at 03:54:10PM -0600, Rob Herring wrote:
> On Wed, May 15, 2019 at 11:19 AM Paul Walmsley <paul.walmsley@xxxxxxxxxx> wrote:
> >
> > RISC-V cores contain basic interrupt controllers, described in
> > DT 'cpus' data in the form:
> >
> >         cpu@0 {
> >                 [... other CPU properties ...]
> >                 interrupt-controller {
> >                         #interrupt-cells = <1>;
> >                         compatible = "riscv,cpu-intc";
> >                         interrupt-controller;
> >                 };
> >         };
> >
> > Since the existing interrupts meta-schema requires the type of the
> > "interrupt-controller" node to be a boolean, it doesn't support this
> > usage.  Support this by relaxing the type constraint on
> > "interrupt-controller" nodes to also accept objects.  Since this usage
> > does not require an "#interrupt-cells" node at the same tree depth as
> > the "interrupt-controller" object, remove the dependency accordingly.
> >
> > Signed-off-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > Cc: Rob Herring <robh@xxxxxxxxxx>
> > ---
> >  meta-schemas/interrupts.yaml | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
>
> Applied, thanks.

It looks like it breaks the tests though:
https://travis-ci.org/devicetree-org/dt-schema/builds/543946648

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]

  Powered by Linux