On Mon, Aug 06, 2018 at 02:56:14PM -0600, Rob Herring wrote: > On Mon, Aug 6, 2018 at 2:30 PM Robert P. J. Day <rpjday@xxxxxxxxxxxxxx> wrote: > > > > On Mon, 6 Aug 2018, Rob Herring wrote: > > > > > On Mon, Aug 6, 2018 at 11:50 AM Robert P. J. Day <rpjday@xxxxxxxxxxxxxx> wrote: > > > > > > > > > > > > While the "device_type" property is still used and supported, it > > > > is deprecated so it should be removed from examples in the > > > > documentation. There is no value in encouraging developers to keep > > > > using that property, so just quietly disappear it from examples, > > > > but leave its explanation in the spec. > > > > > > > > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx> > > > > > > > > --- > > > > > > > > according to the spec, that property is still marginally > > > > acceptable for memory and cpu nodes, but it really has no place > > > > being used for any other types of nodes. > > > > > > It's not just acceptable, but it is still required. It is also > > > required for PCI bridges. > > > > uh ... if it's technically still "required", it cannot possibly be > > deprecated. that's a contradiction. > > Deprecated for new users beyond memory, cpu, and pci. How's that? > > It's been this way for at least the 8+ years I've been involved with > DT and no one has cared. Updating the spec other than perhaps > clarifying the status quo is not the first step. It's removing > dependencies from client programs. > > Just look at all the occurrences in the kernel: > > $ git grep of_find_node_by_type | wc > 76 398 6016 > > And this doesn't include any matching by type in drivers. But then > some of these are valid because device_type is still valid for true OF > based systems like PowerMacs. Right. For those unfamiliar with the history, device_type specifies which set of Forth interfaces the devices supports under OF. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
