Re: [PATCH] Revert change to fsl,mpc8641 example

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Wed, Dec 20, 2017 at 3:35 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
> On Wed, Dec 20, 2017 at 5:20 AM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
>> Commit 7d888a01, "Aesthetic/grammar fixes to first part of
>> devicetree-basics.rst" changed one of the Freescale compatible examples
>> from "fsl,mpc8641-uart" to "fsl,ns16550". However, there is value in
>> using examples from real hardware when possible, and to also show that
>> different strings (mpc8641-uart vs. ns16550) for a device is normal, so
>> revert that hunk.
>>
>> Signed-off-by: Grant Likely <grant.likely@xxxxxxx>
>> Cc: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
>> ---
>>  source/devicetree-basics.rst | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/source/devicetree-basics.rst b/source/devicetree-basics.rst
>> index f007a4b..1900cc8 100644
>> --- a/source/devicetree-basics.rst
>> +++ b/source/devicetree-basics.rst
>> @@ -469,10 +469,10 @@ Description:
>>
>>  Example:
>>
>> -   ``compatible = "fsl,ns16550", "ns16550";``
>> +   ``compatible = "fsl,mpc8641", "ns16550";``
>
> Missing the "-uart" part.

Well, that's embarrassing, and I've already cut the v0.2 release. :-(
That's what I get for trying to do last minute changes.

Oh well. I've posted a fixup and it will show up in v0.3

Cheers,
g.

>
>>
>>     In this example, an operating system would first try to locate a device
>> -   driver that supported fsl,ns16550. If a driver was not found, it
>> +   driver that supported fsl,mpc8641. If a driver was not found, it
>>     would then try to locate a driver that supported the more general
>>     ns16550 device type.
>>
>> --
>> 2.11.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree-spec" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree-spec" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]

  Powered by Linux