On Sat, Mar 01, 2025 at 06:55:02PM +0530, Ayush Singh wrote:
> - Add helper to allocate new marker
>
> Signed-off-by: Ayush Singh <ayush@xxxxxxxxxxxxxxx>
Reviewed-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
This patch is a reasonable cleanup, regardless of what happens with
the rest of the series.
> ---
> data.c | 20 +++++++++++++++-----
> dtc.h | 2 ++
> 2 files changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/data.c b/data.c
> index 14734233ad8b7ebd38c3e62442b81aae66601806..913796f2e664d07cdc48e0cbf2ab5d6fe9978072 100644
> --- a/data.c
> +++ b/data.c
> @@ -228,11 +228,7 @@ struct data data_add_marker(struct data d, enum markertype type, char *ref)
> {
> struct marker *m;
>
> - m = xmalloc(sizeof(*m));
> - m->offset = d.len;
> - m->type = type;
> - m->ref = ref;
> - m->next = NULL;
> + m = alloc_marker(d.len, type, ref);
>
> return data_append_markers(d, m);
> }
> @@ -254,3 +250,17 @@ bool data_is_one_string(struct data d)
>
> return true;
> }
> +
> +struct marker *alloc_marker(unsigned int offset, enum markertype type,
> + char *ref)
> +{
> + struct marker *m;
> +
> + m = xmalloc(sizeof(*m));
> + m->offset = offset;
> + m->type = type;
> + m->ref = ref;
> + m->next = NULL;
> +
> + return m;
> +}
> diff --git a/dtc.h b/dtc.h
> index 4c4aaca1fc417c9d93e904e64b2c40216ee1b093..86928e1eea9764fe5d74d6dbb987589d65d54b66 100644
> --- a/dtc.h
> +++ b/dtc.h
> @@ -183,6 +183,8 @@ struct data data_append_byte(struct data d, uint8_t byte);
> struct data data_append_zeroes(struct data d, int len);
> struct data data_append_align(struct data d, int align);
>
> +struct marker *alloc_marker(unsigned int offset, enum markertype type,
> + char *ref);
> struct data data_add_marker(struct data d, enum markertype type, char *ref);
>
> bool data_is_one_string(struct data d);
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
