On Fri, Dec 13, 2024 at 8:14 AM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > The device tree specification (v0.4) suggests that #address-cells is > mandatory for interrupt parent nodes. If this property is missing, Linux > will default to the value of 0. > > A number of device tree files rely on Linux' fallback and don't specify > an explicit #address-cells as suggested by the specification. This can > cause issues when these device trees are passed to software with a more > pedantic interpretation of the DT spec. > > Add a warning when this case is detected so that device tree files can > be fixed. > > Reported-by: Brad Griffis <bgriffis@xxxxxxxxxx> > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > --- > Applying this to Linux' copy reports on the order of 1300 issues that > originate from 29 .dtsi files. If this proposal is acceptable/useful, I > volunteer to patch those up so we don't get spammed by them. I could have sworn I did a check for this, but it seems not. > --- > checks.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>