Hmmm... in the above examples, using --annotate on a single source file, it is not immediately evident whether the existing annotation logic within dtc handles "append-property" across multiple dts(i) files properly. As you can see, the -T (annotate) and -T -T (detailed annotate) options will add inline comments in the final unified device-tree with the actual source file:line. This is a critical feature in managing complex hierarchies of dtsi files being included in a dts. Until now (without the append-property keyword), IIUC, there can be ONLY one source file/line responsible for a line in the final unified device-tree. The latest line specifying a property overwrites all other specifications of a property before it. With the introduction of this append-property keyword, now more than one file:line can be a source of a line in the final unified device-tree. So, i wonder how the annotations will look like in the scenario in which more than one source file:line is responsible for the content of a single line in the final unified device-tree. If by any chance there is insufficient annotation containing of all the lines responsible for the final "appended list", i worry it will be a nightmare to identify the source of the resulting "appended list" of values being assigned to a property. regards CVS
