Hello,
On Fri, Apr 28, 2023 at 09:11:45PM +0200, Uwe Kleine-König wrote:
> > > @@ -219,6 +219,9 @@ static void write_propval(FILE *f, struct property *prop)
> > > if (emit_type == TYPE_NONE || chunk_len == 0)
> > > continue;
> > >
> > > + if (m->offset != 0)
> > > + fputc(' ', f);
> >
> > I'm not sure how this change is related to anything else.
>
> Without this, the resulting dts might have:
>
> clocks = <&clk 17&clk 19>;
>
> I think before my patch this never happend in practise because an array
> never had more than one marker?!
That hunk is wrong, but I don't see the right fix. A reproducer is:
diff --git a/tests/type-preservation.dts b/tests/type-preservation.dts
index 921ea21172d1..38e97cee6353 100644
--- a/tests/type-preservation.dts
+++ b/tests/type-preservation.dts
@@ -18,6 +18,7 @@
a-string-with-nulls = "foo\0bar", "baz";
a-phandle = <&subsub1>;
a-phandle-with-args = <&subsub1 0x00 0x01>, <&subsub1 0x02 0x03>;
+ another-phandle-with-args = <&subsub1 0x00 0x01 &subsub1 0x02 0x03>;
subsub1: subsubnode {
compatible = "subsubnode1", "subsubnode";
Maybe you see the right thing to do?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
