On Thu, Feb 02, 2023 at 06:08:20PM +0100, Luca Weiss wrote: > On Donnerstag, 2. Februar 2023 07:38:05 CET David Gibson wrote: > > On Wed, Feb 01, 2023 at 01:20:51PM -0700, Simon Glass wrote: > > > Hi Luca, > > > > > > On Wed, 1 Feb 2023 at 11:16, Luca Weiss <luca@xxxxxxxxx> wrote: > > > > This also enables us to test the -NOSPACE condition by adding a test > > > > setting size_hint=1 so this path is taken. > > > > --- > > > > Follow-up from "pylibfdt: add FdtRo.get_path()" from April 2022 > > > > > > > > pylibfdt/libfdt.i | 8 ++++---- > > > > tests/pylibfdt_tests.py | 1 + > > > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > > > Can you add a motivation for this? Why are the paths so long? > > > > I'm also curious about that. > > Please see this for context: > https://www.spinics.net/lists/devicetree-compiler/msg03922.html > > Basically just for the new test. Ah, ok, I'd forgotten that discussion, sorry. > > > Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx> > > > > Code looks sane, so > > > > Reviewed-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> > > > > Unfortunately, I have no way to test this until > > https://github.com/dgibson/dtc/issues/78 is fixed. So, turns out this was triggered by something bogus in my git state. I'm not sure what went wrong in the first place, but I've gotten around it by making myself a new clone. > > Also, I'll need a Signed-off-by line in order to apply this change > > (see CONTRIBUTING.md for details). > > Right. > > Signed-off-by: Luca Weiss <luca@xxxxxxxxx> > > If I should resend with it, please let me know. That will do, thanks. Applied. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
