Re: [PATCH] checks: Suppress warnings on overlay fragments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Jan 10, 2023 at 8:35 PM Qun-Wei Lin <qun-wei.lin@xxxxxxxxxxxx> wrote:
>
> The overlay fragment is a speial case where some properties are not

special

> present in the overlay source file, but in the base file.
>
> example:
> +-----------------------------+--------------------+
> | base.dts                    | overlay.dts        |
> +-----------------------------+--------------------+
> | /dts-v1/;                   | /dts-v1/;          |
> |                             | /plugin/;          |
> | /{                          |                    |
> |   parent: test {            | &parent {          |
> |     #address-cells = <1>;   |   child@0 {        |
> |     #size-cells = <0>;      |     reg = <0x0>;   |
> |   };                        |   };               |
> | };                          | };                 |
> +-----------------------------+--------------------+
>
> It will cause the following false alarms when compiling the overlay dts.
>
> 1. /fragment@0/__overlay__: Character '_' not recommended in node name
> 2. /fragment@0/__overlay__: Relying on default #address-cells value
> 3. /fragment@0/__overlay__: Relying on default #size-cells value
> 4. /fragment@0/__overlay__:reg: property has invalid length (4 bytes)
>    (#address-cells == 2, #size-cells == 1)
>
> This workaround will fix them by skip checking for node named __overlay__.
>
> Signed-off-by: Qun-Wei Lin <qun-wei.lin@xxxxxxxxxxxx>
> ---
>  checks.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/checks.c b/checks.c
> index 9f31d26..afa8f23 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -325,6 +325,9 @@ static void check_node_name_chars_strict(struct check *c, struct dt_info *dti,
>  {
>         int n = strspn(node->name, c->data);
>
> +       if (streq(node->name, "__overlay__"))

Do we hit the same thing with __fixups__ or __local_fixups__? If so,
just skip anything starting with "__".

> +               return;
> +
>         if (n < node->basenamelen)
>                 FAIL(c, dti, node, "Character '%c' not recommended in node name",
>                      node->name[n]);
> @@ -767,6 +770,9 @@ static void check_reg_format(struct check *c, struct dt_info *dti,
>                 return;
>         }
>
> +       if (streq(node->parent->name, "__overlay__"))

Move this to a helper: is_overlay_node(node->parent)

> +               return;
> +
>         if (prop->val.len == 0)
>                 FAIL_PROP(c, dti, node, prop, "property is empty");
>
> @@ -1197,6 +1203,10 @@ static void check_avoid_default_addr_size(struct check *c, struct dt_info *dti,
>         if (!node->parent)
>                 return; /* Ignore root node */
>
> +

Extra blank line.

> +       if (streq(node->parent->name, "__overlay__"))
> +               return;
> +
>         reg = get_property(node, "reg");
>         ranges = get_property(node, "ranges");
>
> --
> 2.18.0
>



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux