Re: [PATCH 2/2] setup.py: fix out of tree build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Mon, Jan 3, 2022 at 1:39 AM <marcandre.lureau@xxxxxxxxxx> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>

$subject is a non-feature IMO. Please see the my recent reply to your
patch from a year ago.

IMO, we should keep meson/Makefile and setup.py builds/tooling
separate. Each has their own ideas about how things work. The path
handling hacks that were in setup.py are just going to cause more
problems when we move to the new Python way with setup.cfg^W
pyproject.toml.

Rob
>
> Fixes: commit 1cc41b1c9 ("pylibfdt: Add packaging metadata")
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> ---
>  setup.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/setup.py b/setup.py
> index 00444e64337b..029aa6182221 100755
> --- a/setup.py
> +++ b/setup.py
> @@ -17,7 +17,7 @@ import sys
>
>  srcdir = os.path.dirname(__file__)
>
> -with open("README", "r") as fh:
> +with open(os.path.join(srcdir, "README"), "r") as fh:
>      long_description = fh.read()
>
>  def get_top_builddir():
> --
> 2.34.1.8.g35151cf07204
>




[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux